Skip to content

Comments

Add dependency on recurrent package#3

Open
mddub wants to merge 1 commit intoopenaps:masterfrom
mddub:wip/require-recurrent
Open

Add dependency on recurrent package#3
mddub wants to merge 1 commit intoopenaps:masterfrom
mddub:wip/require-recurrent

Conversation

@mddub
Copy link

@mddub mddub commented May 9, 2016

6181fc introduced a dependency on recurrent. Got this error after installing openaps on a fresh Pi via quick-src.sh:

pi@markpi:~/markps $ openaps use pump -h
Traceback (most recent call last):
  File "/usr/local/bin/openaps-use", line 4, in <module>
    __import__('pkg_resources').run_script('openaps==0.1.0', 'openaps-use')
  File "build/bdist.linux-armv7l/egg/pkg_resources/__init__.py", line 719, in run_script
  File "build/bdist.linux-armv7l/egg/pkg_resources/__init__.py", line 1504, in run_script
  File "/usr/local/lib/python2.7/dist-packages/openaps-0.1.0-py2.7.egg/EGG-INFO/scripts/openaps-use", line 63, in <module>
    app( )
  File "/usr/local/lib/python2.7/dist-packages/openaps-0.1.0-py2.7.egg/openaps/cli/__init__.py", line 47, in __call__
    self.configure_parser(self.parser)
  File "/usr/local/lib/python2.7/dist-packages/openaps-0.1.0-py2.7.egg/EGG-INFO/scripts/openaps-use", line 31, in configure_parser
    available = devices.get_device_map(self.config)
  File "/usr/local/lib/python2.7/dist-packages/openaps-0.1.0-py2.7.egg/openaps/devices/__init__.py", line 21, in get_device_map
    for device in Device.FromConfig(vendors, conf):
  File "/usr/local/lib/python2.7/dist-packages/openaps-0.1.0-py2.7.egg/openaps/devices/device.py", line 77, in FromConfig
    vendor = vendors.lookup(config.get(candidate, 'vendor').split('.').pop( ), config)
  File "/usr/local/lib/python2.7/dist-packages/openaps-0.1.0-py2.7.egg/openaps/vendors/__init__.py", line 27, in lookup
    return get_map(config)[name]
  File "/usr/local/lib/python2.7/dist-packages/openaps-0.1.0-py2.7.egg/openaps/vendors/__init__.py", line 22, in get_map
    vendors = all_vendors(config)
  File "/usr/local/lib/python2.7/dist-packages/openaps-0.1.0-py2.7.egg/openaps/vendors/__init__.py", line 36, in all_vendors
    return get_vendors( ) + find_plugins(config)
  File "/usr/local/lib/python2.7/dist-packages/openaps-0.1.0-py2.7.egg/openaps/vendors/__init__.py", line 16, in find_plugins
    return [ v.get_module( ) for v in vendors ]
  File "/usr/local/lib/python2.7/dist-packages/openaps-0.1.0-py2.7.egg/openaps/vendors/plugins/vendor.py", line 19, in get_module
    return importlib.import_module(self.name)
  File "/usr/lib/python2.7/importlib/__init__.py", line 37, in import_module
    __import__(name)
  File "/usr/local/lib/python2.7/dist-packages/openaps_contrib-0.0.8-py2.7.egg/openapscontrib/timezones/__init__.py", line 129, in <module>
    import recurrent
ImportError: No module named recurrent

@scottleibrand
Copy link

scottleibrand commented May 9, 2016

Probably should target this to openaps:dev instead of master.

@mddub
Copy link
Author

mddub commented May 9, 2016 •
edited
Loading

Tangential: I noticed there's a dev branch with 0.0.6 stubbed out even though you're up to 0.0.8 on master, might want to kill that.

@mddub
Copy link
Author

mddub commented May 9, 2016

(@scottleibrand ^ this repo does not appear to use dev for release staging as openaps does)

@scottleibrand
Copy link

scottleibrand commented May 9, 2016

Ah, ok. Nevermind me then. This looks good to me, assuming you or someone has tested it and it properly installs the dependency.

@mddub
Copy link
Author

mddub commented May 9, 2016

Oops, I misspoke: I used quick-packages.sh to get that error. quick-src.sh actually works because it checks out and installs the dev branch (which is behind master).

So either this repo should merge master into dev and start using the latter for development (after merging this PR!), or quick-src.sh should be updated to checkout master for this repo as it does for dexcom_reader.

(But yes, I just tested this via sudo pip install -e . and it works.)

@scottleibrand
Copy link

scottleibrand commented May 9, 2016

Ok. Tagging @bewest for his preferences on managing dev vs. master in openaps-contrib. Happy to update quick-src.sh if needed, or help merge openaps-contrib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mddub @scottleibrand